Skip to content

feat: Settings building and validation#77

Merged
redaranj merged 1 commit into
contentauth:mainfrom
redaranj:feature/settings-apis
Mar 27, 2026
Merged

feat: Settings building and validation#77
redaranj merged 1 commit into
contentauth:mainfrom
redaranj:feature/settings-apis

Conversation

@redaranj
Copy link
Copy Markdown
Member

@redaranj redaranj commented Mar 5, 2026

Changes in this pull request

  • Adds features for building and validating JSON for the settings API

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • All applicable changes have been documented
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment

@redaranj redaranj changed the title [3] Feat: Settings APIs [3] Feat: Settings building and validation Mar 5, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 5, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 85.92965% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.96%. Comparing base (71a9136) to head (506dda6).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
Library/Sources/C2PASettings.swift 64.40% 21 Missing ⚠️
Library/Sources/SettingsDefinition.swift 95.00% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
+ Coverage   76.99%   78.96%   +1.96%     
==========================================
  Files          42       44       +2     
  Lines        1313     1512     +199     
==========================================
+ Hits         1011     1194     +183     
- Misses        302      318      +16
Flag Coverage Δ
unittests 78.96% <85.92%> (+1.96%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@redaranj redaranj force-pushed the feature/settings-apis branch 2 times, most recently from df51b56 to 14cbe03 Compare March 12, 2026 13:07
@redaranj redaranj force-pushed the feature/settings-apis branch 2 times, most recently from f797822 to db5498e Compare March 26, 2026 12:40
@redaranj redaranj force-pushed the feature/settings-apis branch from db5498e to 506dda6 Compare March 26, 2026 12:54
scouten-adobe
scouten-adobe approved these changes Mar 26, 2026
View reviewed changes
Comment thread .github/workflows/check-schema-changes.yml

### Action Required

Review the upstream schema changes and update `C2PASettingsDefinition` in \
Copy link
Copy Markdown
Contributor

@scouten-adobe scouten-adobe Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@scouten-adobe scouten-adobe changed the title [3] Feat: Settings building and validation feat: Settings building and validation Mar 26, 2026
@redaranj redaranj merged commit 9823121 into contentauth:main Mar 27, 2026
6 checks passed
@redaranj redaranj mentioned this pull request Apr 16, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scouten-adobe scouten-adobe scouten-adobe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@redaranj @scouten-adobe